]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf/core: Fix pmus_lock vs. pmus_srcu ordering
authorPeter Zijlstra <peterz@infradead.org>
Mon, 4 Nov 2024 13:39:11 +0000 (14:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 12:02:04 +0000 (13:02 +0100)
commit1688acf47722ee5ee2352fe4cf2f0c1769fc92d0
tree39449fdf75044aa7c4d4c36d7e0d843bf8e19317
parent56cddf71cce3b15b078e937fadab29962b6f6643
perf/core: Fix pmus_lock vs. pmus_srcu ordering

[ Upstream commit 2565e42539b120b81a68a58da961ce5d1e34eac8 ]

Commit a63fbed776c7 ("perf/tracing/cpuhotplug: Fix locking order")
placed pmus_lock inside pmus_srcu, this makes perf_pmu_unregister()
trip lockdep.

Move the locking about such that only pmu_idr and pmus (list) are
modified while holding pmus_lock. This avoids doing synchronize_srcu()
while holding pmus_lock and all is well again.

Fixes: a63fbed776c7 ("perf/tracing/cpuhotplug: Fix locking order")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20241104135517.679556858@infradead.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/events/core.c