]> git.ipfire.org Git - thirdparty/squid.git/commit
Coverity detected. inconsistent error detection on StoreIOBUffer
authorAmos Jeffries <amosjeffries@squid-cache.org>
Mon, 6 Oct 2008 11:35:50 +0000 (05:35 -0600)
committerAmos Jeffries <amosjeffries@squid-cache.org>
Mon, 6 Oct 2008 11:35:50 +0000 (05:35 -0600)
commit16f1d46d80c63d17a92d9e37e6bd432a148c3f31
tree9490ff2de25a5d9f234d3c7cdcc90bdc3f6e7e4b
parent02dd5cb79db015f715e2d64917db75cadde2bc64
Coverity detected. inconsistent error detection on StoreIOBUffer

Audit reveals only one of several callers which might set negative length
state were checking for it and setting error flag properly.

Makes more sense for the StoreIOBuffer constructor to do its own
error state detection with information than to offload on callers.
src/StoreIOBuffer.h
src/store_client.cc