]> git.ipfire.org Git - thirdparty/tornado.git/commit
iostream: Deprecate streaming_callback arguments
authorBen Darnell <ben@bendarnell.com>
Sun, 22 Apr 2018 01:58:32 +0000 (21:58 -0400)
committerBen Darnell <ben@bendarnell.com>
Mon, 23 Apr 2018 01:21:00 +0000 (21:21 -0400)
commit172557e49da244a67bc7bfe1438bde5ddbc0f30a
tree531e9b4042d9132a4052cc521653ef444a1bc89a
parent58067883c40b2894b5bdf26dd79c30b6e49207d7
iostream: Deprecate streaming_callback arguments

Currently, mixing futures and streaming_callback does not guarantee
ordering (so the returned future could become ready before the last
streaming_callback fires). Specifically, this happens with
test_streaming_read_until_close_after_close if that test is modified
to not use the callback argument. This would cause problems when we
remove the callback argument if we left streaming_callback in place.

These problems are solvable, but probably not worth it since
partial=True is an alternative (and used internally instead of
streaming_callback).
tornado/iostream.py
tornado/test/iostream_test.py