]> git.ipfire.org Git - thirdparty/linux.git/commit
gpio: htc-egpio: use managed gpiochip registration
authorPengpeng Hou <pengpeng@iscas.ac.cn>
Wed, 24 Jun 2026 13:18:28 +0000 (21:18 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Fri, 26 Jun 2026 09:58:20 +0000 (11:58 +0200)
commit17326db5f0ab4ec1901e75d052b5ebef486b467f
tree863a8b1796a91138b36c47a46d8292e349b957c4
parent479e91fc92416a4d54d2b3150aa1e4550d9cc759
gpio: htc-egpio: use managed gpiochip registration

egpio_probe() registers each nested gpio_chip with gpiochip_add_data()
but ignores the return value. If one registration fails, probe still
returns success even though one of the chips was not published to
gpiolib.

Use devm_gpiochip_add_data() and fail probe if any chip registration
fails. This lets devres unwind already registered chips and prevents
the driver from publishing a partially initialized device.

Fixes: a1635b8fe59d ("[ARM] 4947/1: htc-egpio, a driver for GPIO/IRQ expanders with fixed input/output pins")
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Link: https://patch.msgid.link/20260624131828.94139-1-pengpeng@iscas.ac.cn
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpio-htc-egpio.c