]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5e: fix a potential double-free in fs_udp_create_groups
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Tue, 28 Nov 2023 09:40:53 +0000 (17:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jan 2024 12:38:55 +0000 (12:38 +0000)
commit1750f55d855a6ac3d59cedd059916301c1effb3b
treef1979fb4499f8c2a007be973841efddb826bfe22
parent01877daaeff0b5f42f3b2ee815c5f2e8ba13b4e6
net/mlx5e: fix a potential double-free in fs_udp_create_groups

[ Upstream commit e75efc6466ae289e599fb12a5a86545dff245c65 ]

When kcalloc() for ft->g succeeds but kvzalloc() for in fails,
fs_udp_create_groups() will free ft->g. However, its caller
fs_udp_create_table() will free ft->g again through calling
mlx5e_destroy_flow_table(), which will lead to a double-free.
Fix this by setting ft->g to NULL in fs_udp_create_groups().

Fixes: 1c80bd684388 ("net/mlx5e: Introduce Flow Steering UDP API")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en/fs_tt_redirect.c