]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/i915/ltphy: Nuke bogus weird timeouts
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 6 Nov 2025 15:20:47 +0000 (17:20 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 7 Nov 2025 18:29:43 +0000 (20:29 +0200)
commit177deeea4db7fb1361c0846450a8bfb9814caece
tree3b2744db34d6c3fceb056bd127fb7a9a7a6e113f
parentd4270f090d90a3a5b974e7efdefeec2fe6a41232
drm/i915/ltphy: Nuke bogus weird timeouts

The LT PHY code is abusing intel_de_wait_custom() in all kinds of weird
ways. Get rid of the weird fast timeouts, and just use the slow ones.
For consistency with intel_wait_for_register() we'll stick to the
default 2 usec fast timeout for all cases.

Someone really needs to properly document where all these magic numbers
came from...

This will let us eventually nuke intel_de_wait_custom() and convert
over to poll_timeout_us().

v2: Go for the longer (ms) timeout in case it actually matters

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251106152049.21115-9-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_lt_phy.c
drivers/gpu/drm/i915/display/intel_lt_phy_regs.h