]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Avoid illegal memory access when malformed data is read from the pipe
authorSelva Nair <selva.nair@gmail.com>
Fri, 20 Oct 2017 17:25:56 +0000 (13:25 -0400)
committerGert Doering <gert@greenie.muc.de>
Fri, 3 Nov 2017 18:22:02 +0000 (19:22 +0100)
commit17884fa4ab2b3113559542404704402e5fce7643
tree5ff7439123c81b1132c6bf516c870e244d1aa3eb
parentc5f0ccf1376b6c7e1fe58c87a67b009be3ac9361
Avoid illegal memory access when malformed data is read from the pipe

- If only 1 byte is read from the interactive service client pipe, that
  evaluates to zero wide characters and subsequent check for NUL
  termination in the data buffer segfaults.
  Fix: reject clients that send less than a complete wide character.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1508520356-18277-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15657.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 6f20808c8f37301c43d822f6a22d30b3587abc57)
src/openvpnserv/interactive.c