]> git.ipfire.org Git - thirdparty/iptables.git/commit
Mark fall through cases in switch() statements
authorPhil Sutter <phil@nwl.cc>
Wed, 19 Sep 2018 13:16:45 +0000 (15:16 +0200)
committerFlorian Westphal <fw@strlen.de>
Mon, 24 Sep 2018 09:23:49 +0000 (11:23 +0200)
commit1788f545aae285fa3cd6595d5d25b2ae1b215282
tree18856f67dce467c5f8598947506abb35a1187e39
parent31f1434dfe3770ecbdac1bacb8e0fc4a17b3d671
Mark fall through cases in switch() statements

Typical covscan complaint, non-empty fall throughs should be marked as
such. There was but a single case which should break instead, namely in
libebt_log.c: It is not critical, since the next case merely asserts
'invert' being zero (which can't be as it was checked before). But while
being at it, introduce log_chk_inv() to consolidate the semantically
equal cases for the various log types.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
extensions/libebt_log.c
extensions/libxt_set.c
iptables/nft-shared.c