]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: fix races between buffered IO and collapse / insert range
authorJan Kara <jack@suse.com>
Mon, 7 Dec 2015 19:31:11 +0000 (14:31 -0500)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 23 Mar 2016 14:20:24 +0000 (10:20 -0400)
commit181aaebde9360b8235df647ee36dafdc041d4964
treef10ca11bbf96610fbfc1640a5e6457d36256d7f7
parent9621787d69783fc23d14e1332377d7170d6928ed
ext4: fix races between buffered IO and collapse / insert range

Current code implementing FALLOC_FL_COLLAPSE_RANGE and
FALLOC_FL_INSERT_RANGE is prone to races with buffered writes and page
faults. If buffered write or write via mmap manages to squeeze between
filemap_write_and_wait_range() and truncate_pagecache() in the fallocate
implementations, the written data is simply discarded by
truncate_pagecache() although it should have been shifted.

Fix the problem by moving filemap_write_and_wait_range() call inside
i_mutex and i_mmap_sem. That way we are protected against races with
both buffered writes and page faults.

Signed-off-by: Jan Kara <jack@suse.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Mingming Cao <mingming.cao@oracle.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
fs/ext4/extents.c