]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref
authorPeter Griffin <peter.griffin@linaro.org>
Tue, 20 Feb 2024 11:50:12 +0000 (11:50 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:51 +0000 (18:19 -0400)
commit18421148eed79fa253cff7fba06221079252961b
tree58e3cc05b3696a5f9f4ed6ec2b3869aeef05390b
parent1b01e66c1ce4769adebc5218133a09545e54859f
mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref

[ Upstream commit e28c28a34ee9fa2ea671a20e5e7064e6220d55e7 ]

of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.

Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-4-peter.griffin@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/altera-sysmgr.c