]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netns: provide pure entropy for net_hash_mix()
authorEric Dumazet <edumazet@google.com>
Wed, 27 Mar 2019 15:21:30 +0000 (08:21 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 9 Jul 2019 21:04:22 +0000 (22:04 +0100)
commit188da790e1f4d164bcfdea486e91fd47e1ba59c5
tree4ce30ff09f637f1bf7151d5095cf3e5a4192d44a
parenta62393d7eb63bd075c51154002825cc7ab4dd3eb
netns: provide pure entropy for net_hash_mix()

commit 355b98553789b646ed97ad801a619ff898471b92 upstream.

net_hash_mix() currently uses kernel address of a struct net,
and is used in many places that could be used to reveal this
address to a patient attacker, thus defeating KASLR, for
the typical case (initial net namespace, &init_net is
not dynamically allocated)

I believe the original implementation tried to avoid spending
too many cycles in this function, but security comes first.

Also provide entropy regardless of CONFIG_NET_NS.

Fixes: 0b4419162aa6 ("netns: introduce the net_hash_mix "salt" for hashes")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Amit Klein <aksecurity@gmail.com>
Reported-by: Benny Pinkas <benny@pinkas.net>
Cc: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/net/net_namespace.h
include/net/netns/hash.h
net/core/net_namespace.c