]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/msm: dpu: Don't set frame_busy_mask for async updates
authorSean Paul <seanpaul@chromium.org>
Wed, 30 Jan 2019 16:32:12 +0000 (11:32 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:45:03 +0000 (06:45 -0700)
commit18a3357193c9b249261b48f503d342770eab0a02
tree1da6ed512e76824d392055d31dcfc6efa2ea93e1
parentf66ce9381b5a6c313f5739d9bb800a93946925d6
drm/msm: dpu: Don't set frame_busy_mask for async updates

[ Upstream commit f98baa3109cea46083d2361ab14a0207d1b1bd16 ]

The frame_busy mask is used in frame_done event handling, which is not
invoked for async commits. So an async commit will leave the
frame_busy mask populated after it completes and future commits will start
with the busy mask incorrect.

This showed up on disable after cursor move. I was hitting the "this should
not happen" comment in the frame event worker since frame_busy was set,
we queued the event, but there were no frames pending (since async
also doesn't set that).

Reviewed-by: Fritz Koenig <frkoenig@google.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190130163220.138637-1-sean@poorly.run
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c