]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
interconnect: debugfs: Fix incorrect error handling for NULL path
authorKuan-Wei Chiu <visitorckw@gmail.com>
Fri, 10 Oct 2025 15:14:47 +0000 (23:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:02:46 +0000 (14:02 +0100)
commit18fe7b456f99c478a1d7cc3fd66ec2eacfeb8f66
tree58e8736a4f441f6635dcddb6e7a07466df072c68
parent14700e6b28f3e21fe9fe2f506b6d4e45c289f37f
interconnect: debugfs: Fix incorrect error handling for NULL path

[ Upstream commit 6bfe104fd0f94d0248af22c256ce725ee087157b ]

The icc_commit_set() function, used by the debugfs interface, checks
the validity of the global cur_path pointer using IS_ERR_OR_NULL().
However, in the specific case where cur_path is NULL, while
IS_ERR_OR_NULL(NULL) correctly evaluates to true, the subsequent call
to PTR_ERR(NULL) returns 0.

This causes the function to return a success code (0) instead of an
error, misleading the user into believing their bandwidth request was
successfully committed when, in fact, no operation was performed.

Fix this by adding an explicit check to return -EINVAL if cur_path is
NULL. This prevents silent failures and ensures that an invalid
operational sequence is immediately and clearly reported as an error.

Fixes: 770c69f037c1 ("interconnect: Add debugfs test client")
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Link: https://lore.kernel.org/r/20251010151447.2289779-1-visitorckw@gmail.com
Signed-off-by: Georgi Djakov <djakov@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/interconnect/debugfs-client.c