]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
closes bpo-39605: Fix some casts to not cast away const. (GH-18453)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 12 Feb 2020 02:47:20 +0000 (18:47 -0800)
committerGitHub <noreply@github.com>
Wed, 12 Feb 2020 02:47:20 +0000 (18:47 -0800)
commit190433d8150bf719fa0ba972dbacf2214942f54e
tree542d09915c36b8e496c0c66950eb0bf29704e271
parent0f0d2e496205c345b182b6572ee09db23f8f9daf
closes bpo-39605: Fix some casts to not cast away const. (GH-18453)

gcc -Wcast-qual turns up a number of instances of casting away constness of pointers. Some of these can be safely modified, by either:

Adding the const to the type cast, as in:

-    return _PyUnicode_FromUCS1((unsigned char*)s, size);
+    return _PyUnicode_FromUCS1((const unsigned char*)s, size);

or, Removing the cast entirely, because it's not necessary (but probably was at one time), as in:

-    PyDTrace_FUNCTION_ENTRY((char *)filename, (char *)funcname, lineno);
+    PyDTrace_FUNCTION_ENTRY(filename, funcname, lineno);

These changes will not change code, but they will make it much easier to check for errors in consts
(cherry picked from commit e6be9b59a911626d6597fe148c32f0342bd2bd24)

Co-authored-by: Andy Lester <andy@petdance.com>
Modules/_io/textio.c
Objects/bytes_methods.c
Objects/memoryobject.c
Objects/stringlib/asciilib.h
Objects/stringlib/codecs.h
Objects/stringlib/find_max_char.h
Objects/unicodeobject.c
Python/marshal.c
Python/pyhash.c