]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: siano: Fix error handling in smsdvb_module_init()
authorYuan Can <yuancan@huawei.com>
Tue, 22 Oct 2024 06:50:37 +0000 (14:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:45:22 +0000 (10:45 +0200)
commit192b87608c2ccadf0c1fb239fa30334a374ff515
tree704226a55f2b202bf5def3908cf58d8ce056096f
parent3e7fc0606e717063433872bd67a113bf8bf40316
media: siano: Fix error handling in smsdvb_module_init()

commit 734ac57e47b3bdd140a1119e2c4e8e6f8ef8b33d upstream.

The smsdvb_module_init() returns without checking the retval from
smscore_register_hotplug().
If the smscore_register_hotplug() failed, the module failed to install,
leaving the smsdvb_debugfs not unregistered.

Fixes: 3f6b87cff66b ("[media] siano: allow showing the complete statistics via debugfs")
Cc: stable@vger.kernel.org
Signed-off-by: Yuan Can <yuancan@huawei.com>
Acked-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/common/siano/smsdvb-main.c