]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue
authorVitaly Lifshits <vitaly.lifshits@intel.com>
Sun, 3 Mar 2024 10:51:32 +0000 (12:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:35:57 +0000 (16:35 +0200)
commit199a1314ef78ac1a95e28d1d754f0e18aa960f65
tree9a2543a6fa091e4eb5b536d66587f32cc68879ea
parenteb96a5c025533ba42eb2a16559e6a4e90d4dfe9e
e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

[ Upstream commit 861e8086029e003305750b4126ecd6617465f5c7 ]

Forcing SMBUS inside the ULP enabling flow leads to sporadic PHY loss on
some systems. It is suspected to be caused by initiating PHY transactions
before the interface settles.

Separating this configuration from the ULP enabling flow and moving it to
the shutdown function allows enough time for the interface to settle and
avoids adding a delay.

Fixes: 6607c99e7034 ("e1000e: i219 - fix to enable both ULP and EEE in Sx state")
Co-developed-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Signed-off-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/intel/e1000e/ich8lan.c
drivers/net/ethernet/intel/e1000e/netdev.c