]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: microchip-core: use XOR instead of ANDNOT to fix the logic
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 8 Jan 2026 17:49:40 +0000 (18:49 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 8 Jan 2026 20:06:30 +0000 (20:06 +0000)
commit19a4505a7a5d4eea70f1a42d601c25d730922fdf
treeb23fe28cdf913f44be2c2686763048f7c648ccd5
parent36227ab99a781a02b3448b79fb15f2a20dc7f10b
spi: microchip-core: use XOR instead of ANDNOT to fix the logic

Use XOR instead of ANDNOT to fix the logic. The current approach with
(foo & BAR & ~baz) is harder to process, and it proved to be wrong,
than more usual pattern for the comparing misconfiguration using
((foo ^ baz) & BAR) which can be read as "find all different bits
between foo and baz that are related to BAR (mask)". Besides that
it makes the binary code shorter.

Function                                     old     new   delta
mchp_corespi_setup                           103      99      -4

Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller")
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Tested-by: Prajna Rajendra Kumar <prajna.rajendrakumar@microchip.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20260108175100.3535306-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-microchip-core-spi.c