]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
SUNRPC: Add an IS_ERR() check back to where it was
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 11 Oct 2023 08:00:22 +0000 (11:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:07:03 +0000 (17:07 +0000)
commit19d7dbf71ecc9445879dc07b1233f7cc9d93963c
tree0d973856b35dcc256bfd973905194b33af948cc4
parentc65b915641d82ae9622059ee0fb07ea5b5894150
SUNRPC: Add an IS_ERR() check back to where it was

[ Upstream commit 4f3ed837186fc0d2722ba8d2457a594322e9c2ef ]

This IS_ERR() check was deleted during in a cleanup because, at the time,
the rpcb_call_async() function could not return an error pointer.  That
changed in commit 25cf32ad5dba ("SUNRPC: Handle allocation failure in
rpc_new_task()") and now it can return an error pointer.  Put the check
back.

A related revert was done in commit 13bd90141804 ("Revert "SUNRPC:
Remove unreachable error condition"").

Fixes: 037e910b52b0 ("SUNRPC: Remove unreachable error condition in rpcb_getport_async()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sunrpc/rpcb_clnt.c