]> git.ipfire.org Git - thirdparty/tor.git/commit
Prevention: never die from extend_info_from_node() failure.
authorNick Mathewson <nickm@torproject.org>
Fri, 3 Feb 2017 15:14:25 +0000 (10:14 -0500)
committerNick Mathewson <nickm@torproject.org>
Fri, 3 Feb 2017 15:35:07 +0000 (10:35 -0500)
commit19e25d5cabd23f28044ccbddc01e5cacbde2cfcb
tree5c7d209abd9dc33ab61990e05c783940e623dcd1
parent9d5a9feb404c61d93309eea1c68fcae3ff0cf8f3
Prevention: never die from extend_info_from_node() failure.

Bug 21242 occurred because we asserted that extend_info_from_node()
had succeeded...even though we already had the code to handle such a
failure.  We fixed that in 93b39c51629ed0ded2bf807cb6.

But there were four other cases in our code where we called
extend_info_from_node() and either tor_assert()ed that it returned
non-NULL, or [in one case] silently assumed that it returned
non-NULL. That's not such a great idea.  This patch makes those
cases check for a bug of this kind instead.

Fixes bug 21372; bugfix on 0.2.3.1-alpha when
extend_info_from_node() was introduced.
changes/bug21372 [new file with mode: 0644]
src/or/circuitbuild.c
src/or/control.c
src/or/rendservice.c