]> git.ipfire.org Git - thirdparty/samba.git/commit
s3:rpc_client: reverse rpccli_{is_connected,set_timeout}() and rpccli_bh_{is_connecte...
authorStefan Metzmacher <metze@samba.org>
Fri, 7 Aug 2020 13:57:15 +0000 (15:57 +0200)
committerStefan Metzmacher <metze@samba.org>
Sat, 8 Aug 2020 09:36:28 +0000 (09:36 +0000)
commit19ef9c40f14f91fcae6874d9f94540dd850e308b
tree6cfbc6526c3341eed9687fe3f4a8bcb8bdf735a6
parent6a9c78592814543e69e39f4451c8d0ef7e4dcf6b
s3:rpc_client: reverse rpccli_{is_connected,set_timeout}() and rpccli_bh_{is_connected,set_timeout}()

rpccli->transport should never be used directly,
everything should go via the binding handle.

Internal pipes don't have a transport, so p->transport is always
NULL. rpccli_is_connected() checks this and this causes all SAMR and LSA
requests for the local domain to be processed a second time by the triggered
retry logic.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14457

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/rpc_client/cli_pipe.c