]> git.ipfire.org Git - thirdparty/asterisk.git/commit
Fix potential crash from race condition due to accessing channel data without the...
authorMark Michelson <mmichelson@digium.com>
Fri, 30 Apr 2010 20:08:15 +0000 (20:08 +0000)
committerMark Michelson <mmichelson@digium.com>
Fri, 30 Apr 2010 20:08:15 +0000 (20:08 +0000)
commit1a098e8e98da5342596933f3e4e93c7e1d66068d
tree99fe0748670372932225c07ad84ac1e3d1c8e55c
parente0d8abbfe20c0b9d1af7bddb5c455a620b2da1fe
Fix potential crash from race condition due to accessing channel data without the channel locked.

In res_musiconhold.c, there are several places where a channel's
stream's existence is checked prior to calling ast_closestream on it. The issue
here is that in several cases, the channel was not locked while checking the
stream. The result was that if two threads checked the state of the channel's
stream at approximately the same time, then there could be a situation where
both threads attempt to call ast_closestream on the channel's stream. The result
here is that the refcount for the stream would go below 0, resulting in a crash.

I have added proper channel locking to res_musiconhold.c to ensure that
we do not try to check chan->stream without the channel locked. A Digium customer
has been using this patch for several weeks and has not had any crashes since
applying the patch.

ABE-2147

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@260345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
res/res_musiconhold.c