]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: sja1000: fix use after free in ems_pcmcia_add_card()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Nov 2021 14:50:41 +0000 (17:50 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 13:48:59 +0000 (14:48 +0100)
commit1a295fea90e1acbe80c6d4940f5ff856edcd6bec
tree959273b17351d4ce0e37123e1b0d378afc067cff
parentfbcb12bc9dbf233d9a7ac6d03ebc74fb592f3614
can: sja1000: fix use after free in ems_pcmcia_add_card()

commit 3ec6ca6b1a8e64389f0212b5a1b0f6fed1909e45 upstream.

If the last channel is not available then "dev" is freed.  Fortunately,
we can just use "pdev->irq" instead.

Also we should check if at least one channel was set up.

Fixes: fd734c6f25ae ("can/sja1000: add driver for EMS PCMCIA card")
Link: https://lore.kernel.org/all/20211124145041.GB13656@kili
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/sja1000/ems_pcmcia.c