]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: compress: prevent potential divide by zero bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Dec 2018 09:06:58 +0000 (12:06 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Mar 2019 16:59:35 +0000 (17:59 +0100)
commit1a2ea3f600719bf251ac12753a3310dad67650b1
tree0e8ba8aad317d495390a6cac3dea3e767204f66a
parent84a6a91bf36cb73fe822afa70256d3b0556ff162
ALSA: compress: prevent potential divide by zero bugs

[ Upstream commit 678e2b44c8e3fec3afc7202f1996a4500a50be93 ]

The problem is seen in the q6asm_dai_compr_set_params() function:

ret = q6asm_map_memory_regions(dir, prtd->audio_client, prtd->phys,
       (prtd->pcm_size / prtd->periods),
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       prtd->periods);

In this code prtd->pcm_size is the buffer_size and prtd->periods comes
from params->buffer.fragments.  If we allow the number of fragments to
be zero then it results in a divide by zero bug.  One possible fix would
be to use prtd->pcm_count directly instead of using the division to
re-calculate it.  But I decided that it doesn't really make sense to
allow zero fragments.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/core/compress_offload.c