]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: musb: Fix trying to free already-free IRQ 4
authorTony Lindgren <tony@atomide.com>
Wed, 4 Jan 2017 00:13:48 +0000 (18:13 -0600)
committerWilly Tarreau <w@1wt.eu>
Wed, 7 Jun 2017 22:46:52 +0000 (00:46 +0200)
commit1a2f2dfba983795f043dc6b4831c84166c2de9d3
tree75e7e398e7c84c4ec94232754ef24f9a4e483653
parent5a45bdd35b88a5ab56c990176f461cd4c529ce9b
usb: musb: Fix trying to free already-free IRQ 4

commit 8c300fe282fa254ea730c92cb0983e2642dc1fff upstream.

When unloading omap2430, we can get the following splat:

WARNING: CPU: 1 PID: 295 at kernel/irq/manage.c:1478 __free_irq+0xa8/0x2c8
Trying to free already-free IRQ 4
...
[<c01a8b78>] (free_irq) from [<bf0aea84>]
(musbhs_dma_controller_destroy+0x28/0xb0 [musb_hdrc])
[<bf0aea84>] (musbhs_dma_controller_destroy [musb_hdrc]) from
[<bf09f88c>] (musb_remove+0xf0/0x12c [musb_hdrc])
[<bf09f88c>] (musb_remove [musb_hdrc]) from [<c056a384>]
(platform_drv_remove+0x24/0x3c)
...

This is because the irq number in use is 260 nowadays, and the dma
controller is using u8 instead of int.

Fixes: 6995eb68aab7 ("USB: musb: enable low level DMA operation for Blackfin")
Signed-off-by: Tony Lindgren <tony@atomide.com>
[b-liu@ti.com: added Fixes tag]
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/usb/musb/musbhsdma.h