]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: fix double inode unlock for direct IO sync writes
authorFilipe Manana <fdmanana@suse.com>
Fri, 2 Aug 2024 08:38:51 +0000 (09:38 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Aug 2024 03:45:49 +0000 (05:45 +0200)
commit1a607d22dea4f60438747705495ec4d0af2ec451
tree212ba79a921c3f3e9f5348f5d5f8ca2d5a03f65b
parentf754591b17d0ee91c2b45fe9509d0cdc420527cb
btrfs: fix double inode unlock for direct IO sync writes

commit e0391e92f9ab4fb3dbdeb139c967dcfa7ac4b115 upstream.

If we do a direct IO sync write, at btrfs_sync_file(), and we need to skip
inode logging or we get an error starting a transaction or an error when
flushing delalloc, we end up unlocking the inode when we shouldn't under
the 'out_release_extents' label, and then unlock it again at
btrfs_direct_write().

Fix that by checking if we have to skip inode unlocking under that label.

Reported-by: syzbot+7dbbb74af6291b5a5a8b@syzkaller.appspotmail.com
Link: https://lore.kernel.org/linux-btrfs/000000000000dfd631061eaeb4bc@google.com/
Fixes: 939b656bc8ab ("btrfs: fix corruption after buffer fault in during direct IO append write")
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/file.c