]> git.ipfire.org Git - thirdparty/git.git/commit
contrib: wire up osxkeychain in contrib/Makefile on macOS
authorShardul Natu <snatu@google.com>
Wed, 8 Jul 2026 03:21:19 +0000 (03:21 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 8 Jul 2026 04:58:55 +0000 (21:58 -0700)
commit1a62c1fc8be2ea7fc8cecde5f31ec83a03c60822
tree3bf3be37088cc45dc4baa7ab631982ca8cd373ab
parent924dfced6b811d1bbe76485d225c789853bef553
contrib: wire up osxkeychain in contrib/Makefile on macOS

When running "make test" with TEST_CONTRIB_TOO=yes (which is default in
macOS CI workflows), $(MAKE) -C contrib/ test is invoked. However,
contrib/Makefile only invoked tests for diff-highlight and subtree,
meaning git-credential-osxkeychain was never built or verified during
standard CI test runs.

Add a "test" target to contrib/credential/osxkeychain/Makefile that
depends on building git-credential-osxkeychain. Additionally, wire up
credential/osxkeychain in contrib/Makefile under "all", "test", and
"clean" whenever running on macOS (Darwin).

This ensures that running "make test" or "make all" in contrib on macOS
automatically builds and links git-credential-osxkeychain, preventing
future build or symbol linking regressions from slipping through CI.

Signed-off-by: Shardul Natu <snatu@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/Makefile
contrib/credential/osxkeychain/Makefile