]> git.ipfire.org Git - thirdparty/kea.git/commit
[5007] Addressed review comments
authorThomas Markwalder <tmark@isc.org>
Fri, 16 Sep 2016 18:27:46 +0000 (14:27 -0400)
committerThomas Markwalder <tmark@isc.org>
Fri, 16 Sep 2016 18:27:46 +0000 (14:27 -0400)
commit1a986cf434453bdf6ccbcef5d707a23a23305093
treefd32a2d1c7af0d12cbfbb5072a37c1444eaf88b5
parent46f4c9fdd841b3cb26afb925b9386fbe3534e89d
[5007] Addressed review comments

This is solution #2:

src/lib/dhcpsrv/alloc_engine.h
src/lib/dhcpsrv/alloc_engine.cc
    AllocEngine::extendLease6() - replaced logic to set the context flags with
    simply adding the original lease to the changed_leases_ list.

    AllocEngine::updateLeaseData() - removed logic to set the context flags.

src/bin/dhcp6/dhcp6_srv.cc
    Dhcpv6Srv::createNameChangeRequests() - replaced the context flag check
    with logic which looks for candidate IA addresses in the ctx.changed_leases_
    list.  If found and the FDQN doman name has not changed, we move on to the
    next candidate.

src/bin/dhcp6/tests/fqdn_unittest.cc
    TEST_F(FqdnDhcpv6SrvTest, createNameChangeRequestsNoAddr) - removed
    testing of context flag permutations
src/bin/dhcp6/dhcp6_srv.cc
src/bin/dhcp6/tests/fqdn_unittest.cc
src/lib/dhcpsrv/alloc_engine.cc
src/lib/dhcpsrv/alloc_engine.h