]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dsa: qca8k: Use nested lock to avoid splat
authorAndrew Lunn <andrew@lunn.ch>
Sun, 10 Nov 2024 17:59:55 +0000 (18:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:55 +0000 (20:03 +0100)
commit1ab42ad28076304f88485d22f1230b6c77030a35
tree48178a65db9a6be5b1b09ab0b246ae3e0657eb11
parent9fbc0ece455e2c008568266f39f9d14628ac3803
dsa: qca8k: Use nested lock to avoid splat

[ Upstream commit 078e0d596f7b5952dad8662ace8f20ed2165e2ce ]

qca8k_phy_eth_command() is used to probe the child MDIO bus while the
parent MDIO is locked. This causes lockdep splat, reporting a possible
deadlock. It is not an actually deadlock, because different locks are
used. By making use of mutex_lock_nested() we can avoid this false
positive.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241110175955.3053664-1-andrew@lunn.ch
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/qca/qca8k-8xxx.c