]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipv6: fix a BUG in rt6_get_pcpu_route() under PREEMPT_RT
authorJiayuan Chen <jiayuan.chen@linux.dev>
Tue, 23 Dec 2025 05:14:12 +0000 (13:14 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 Dec 2025 11:04:36 +0000 (12:04 +0100)
commit1adaea51c61b52e24e7ab38f7d3eba023b2d050d
treeddd0b2ff13da6dca0f0a3c2f5d4e6b26075e0303
parent6595beb40fb0ec47223d3f6058ee40354694c8e4
ipv6: fix a BUG in rt6_get_pcpu_route() under PREEMPT_RT

On PREEMPT_RT kernels, after rt6_get_pcpu_route() returns NULL, the
current task can be preempted. Another task running on the same CPU
may then execute rt6_make_pcpu_route() and successfully install a
pcpu_rt entry. When the first task resumes execution, its cmpxchg()
in rt6_make_pcpu_route() will fail because rt6i_pcpu is no longer
NULL, triggering the BUG_ON(prev). It's easy to reproduce it by adding
mdelay() after rt6_get_pcpu_route().

Using preempt_disable/enable is not appropriate here because
ip6_rt_pcpu_alloc() may sleep.

Fix this by handling the cmpxchg() failure gracefully on PREEMPT_RT:
free our allocation and return the existing pcpu_rt installed by
another task. The BUG_ON is replaced by WARN_ON_ONCE for non-PREEMPT_RT
kernels where such races should not occur.

Link: https://syzkaller.appspot.com/bug?extid=9b35e9bc0951140d13e6
Fixes: d2d6422f8bd1 ("x86: Allow to enable PREEMPT_RT.")
Reported-by: syzbot+9b35e9bc0951140d13e6@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/6918cd88.050a0220.1c914e.0045.GAE@google.com/T/
Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
Link: https://patch.msgid.link/20251223051413.124687-1-jiayuan.chen@linux.dev
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv6/route.c