]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
rtc: isl1208: Balance enable_irq_wake() with disable_irq_wake() on cleanup
authorJohn Madieu <john.madieu.xa@bp.renesas.com>
Sat, 25 Apr 2026 15:49:59 +0000 (15:49 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 22 Jun 2026 21:28:57 +0000 (23:28 +0200)
commit1afe4f19d6ad404621150f0e91feeccf12fb1037
tree376cc68bd49d46e84b30aa9edbdfb927d8240613
parent041ca8884410a4f70b40521f34258c7b773ea5c2
rtc: isl1208: Balance enable_irq_wake() with disable_irq_wake() on cleanup

isl1208_setup_irq() calls enable_irq_wake() after a successful
IRQ request, but the driver has no remove path that balances it.
The driver is devm-only, so on unbind devm releases the IRQ -
but enable_irq_wake() is not undone by IRQ release, so the wake
count for that IRQ stays incremented.

Each rebind therefore leaks one wake reference; the leak doubles
for the chip variant that has a separate evdet IRQ, since
isl1208_setup_irq() is then called twice during probe.

Register a devm action that calls disable_irq_wake() per IRQ.
While at it, check enable_irq_wake()'s return value:
on failure, propagate the error rather than silently registering
a disable action for an IRQ whose wake state was never enabled.

Fixes: 9ece7cd833a3 ("rtc: isl1208: Add "evdet" interrupt source for isl1219")
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
Link: https://patch.msgid.link/20260425154959.2796261-3-john.madieu.xa@bp.renesas.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-isl1208.c