]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref
authorPeter Griffin <peter.griffin@linaro.org>
Tue, 20 Feb 2024 11:50:10 +0000 (11:50 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:51 +0000 (18:19 -0400)
commit1b01e66c1ce4769adebc5218133a09545e54859f
tree41c26c42bea35fdeb87226d90d103fed01551df2
parent81d998e183113845cef5740a88b32f9dc9f02fae
mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref

[ Upstream commit d2b0680cf3b05490b579e71b0df6e07451977745 ]

of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.

Fixes: 45330bb43421 ("mfd: syscon: Allow property as NULL in syscon_regmap_lookup_by_phandle")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-2-peter.griffin@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/syscon.c