]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
clockevent: sun4i: Fix race condition in the probe code
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Tue, 18 Nov 2014 22:59:33 +0000 (23:59 +0100)
committerJiri Slaby <jslaby@suse.cz>
Sat, 6 Dec 2014 14:14:51 +0000 (15:14 +0100)
commit1b0a21003bd3b81a0b935f51f4e6988910cb0ae1
treeb120ed13d154b2eaaa88b56b216d661d760350e7
parent5545f8b0fca9fa9efe65d8084dbb536aebabdb61
clockevent: sun4i: Fix race condition in the probe code

commit 6bab4a8a1888729f17f4923cc5867e4674f66333 upstream.

The interrupts were activated and the handler registered before the clockevent
was registered in the probe function.

The interrupt handler, however, was making the assumption that the clockevent
device was registered.

That could cause a null pointer dereference if the timer interrupt was firing
during this narrow window.

Fix that by moving the clockevent registration before the interrupt is enabled.

Reported-by: Roman Byshko <rbyshko@gmail.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/clocksource/sun4i_timer.c