]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
greybus: gb-beagleplay: Fix timeout handling in bootloader functions
authorHaotian Zhang <vulab@iscas.ac.cn>
Fri, 21 Nov 2025 06:40:27 +0000 (14:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 12:55:08 +0000 (13:55 +0100)
commit1b3eb9500fc558aa383915471bd85a35327b9786
treee5f43b67d3b4e390484c5dee89cac17f95db2ae7
parent80c2106b09d3b8cab3455176151181f05ca5d312
greybus: gb-beagleplay: Fix timeout handling in bootloader functions

[ Upstream commit e6df0f649cff08da7a2feb6d963b39076ca129f9 ]

wait_for_completion_timeout() returns the remaining jiffies
(at least 1) on success or 0 on timeout, but never negative
error codes. The current code incorrectly checks for negative
values, causing timeouts to be ignored and treated as success.

Check for a zero return value to correctly identify and
handle timeout events.

Fixes: 0cf7befa3ea2 ("greybus: gb-beagleplay: Add firmware upload API")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251121064027.571-1-vulab@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/greybus/gb-beagleplay.c