]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
gpio: aspeed: Add the flush write to ensure the write complete.
authorBilly Tsai <billy_tsai@aspeedtech.com>
Tue, 8 Oct 2024 08:14:44 +0000 (16:14 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Oct 2024 14:01:58 +0000 (16:01 +0200)
commit1bb5a99e1f3fd27accb804aa0443a789161f843c
tree6d56586f21346efc2c5c82c21364c650425a80b2
parent8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b
gpio: aspeed: Add the flush write to ensure the write complete.

Performing a dummy read ensures that the register write operation is fully
completed, mitigating any potential bus delays that could otherwise impact
the frequency of bitbang usage. E.g., if the JTAG application uses GPIO to
control the JTAG pins (TCK, TMS, TDI, TDO, and TRST), and the application
sets the TCK clock to 1 MHz, the GPIO's high/low transitions will rely on
a delay function to ensure the clock frequency does not exceed 1 MHz.
However, this can lead to rapid toggling of the GPIO because the write
operation is POSTed and does not wait for a bus acknowledgment.

Fixes: 361b79119a4b ("gpio: Add Aspeed driver")
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20241008081450.1490955-2-billy_tsai@aspeedtech.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-aspeed.c