]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix KDC encrypting key memory leak on some errors
authorGreg Hudson <ghudson@mit.edu>
Tue, 27 Feb 2018 16:56:58 +0000 (11:56 -0500)
committerGreg Hudson <ghudson@mit.edu>
Fri, 2 Mar 2018 15:43:43 +0000 (10:43 -0500)
commit1bcf2742d504a22b7354251bbc1e19c3dacd95f3
tree5db3b9d84c43c088151bb892ccd4a9429d531bb0
parentb0c700608be7455041a8afc0e4502e8783ee7f30
Fix KDC encrypting key memory leak on some errors

Commit 0ba5ccd7bb3ea15e44a87f84ca6feed8890f657d separated the
allocation and destruction of encrypting_key, causing it to leak when
any of the intervening calls jump to the cleanup label.  Currently the
leak manifests on transited or authdata failures.  Move encrypting_key
destruction to the cleanup label so that it can't leak.  Reported by
anedvedicky@gmail.com.

ticket: 8645 (new)
tags: pullup
target_version: 1.16-next
target_version: 1.15-next
src/kdc/do_tgs_req.c