]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tee: qcomtee: user: Fix confusing cleanup.h syntax
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Mon, 8 Dec 2025 02:08:47 +0000 (03:08 +0100)
committerJens Wiklander <jens.wiklander@linaro.org>
Mon, 5 Jan 2026 09:21:09 +0000 (10:21 +0100)
commit1c05d9a4cab2abfb93ebce5edaa17752126b6d35
treeb6029d46e37dd031fba22caad31fa3178612ca47
parent7c4c14ad3d8cbc3507231e3f3bc090dfbfcabf9d
tee: qcomtee: user: Fix confusing cleanup.h syntax

Initializing automatic __free variables to NULL without need (e.g.
branches with different allocations), followed by actual allocation is
in contrary to explicit coding rules guiding cleanup.h:

"Given that the "__free(...) = NULL" pattern for variables defined at
the top of the function poses this potential interdependency problem the
recommendation is to always define and assign variables in one statement
and not group variable definitions at the top of the function when
__free() is used."

Code does not have a bug, but is less readable and uses discouraged
coding practice, so fix that by moving declaration to the place of
assignment.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/qcomtee/user_obj.c