]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xfs: Fix xfs_attr_leafblock definition
authorJan Kara <jack@suse.com>
Wed, 19 Aug 2015 00:34:32 +0000 (10:34 +1000)
committerWilly Tarreau <w@1wt.eu>
Sat, 5 Dec 2015 23:49:08 +0000 (00:49 +0100)
commit1c16d9c6fc1ecbfe57495e000768cf2c17a44f08
tree88beda44be3e45659eff1ede53dabe1209ed675d
parent315daa81f50476eae4e875bfe0e5113bd8f20a3a
xfs: Fix xfs_attr_leafblock definition

commit ffeecc5213024ae663377b442eedcfbacf6d0c5d upstream.

struct xfs_attr_leafblock contains 'entries' array which is declared
with size 1 altough it can in fact contain much more entries. Since this
array is followed by further struct members, gcc (at least in version
4.8.3) thinks that the array has the fixed size of 1 element and thus
may optimize away all accesses beyond the end of array resulting in
non-working code. This problem was only observed with userspace code in
xfsprogs, however it's better to be safe in kernel as well and have
matching kernel and xfsprogs definitions.

Signed-off-by: Jan Kara <jack@suse.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
(cherry picked from commit 86cbc0072fa4fc7906dd8abfa6489638014300bb)

Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/xfs/xfs_attr_leaf.h