]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
power_supply: twl4030_madc: Check return value of power_supply_register
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 20 Feb 2015 13:32:22 +0000 (14:32 +0100)
committerJiri Slaby <jslaby@suse.cz>
Mon, 4 May 2015 09:49:51 +0000 (11:49 +0200)
commit1c36ba3f9ef3d3317693dfcead7c3d989b3801bb
treec0c7f553631108b4362f961cab307ab5dd336715
parentf29084250e0361de2a572a9d27373980fda59eb2
power_supply: twl4030_madc: Check return value of power_supply_register

commit 68c3ed6fa7e0d69529ced772d650ab128916a81d upstream.

The return value of power_supply_register() call was not checked and
even on error probe() function returned 0. If registering failed then
during unbind the driver tried to unregister power supply which was not
actually registered.

This could lead to memory corruption because power_supply_unregister()
unconditionally cleans up given power supply.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: da0a00ebc239 ("power: Add twl4030_madc battery driver.")
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/power/twl4030_madc_battery.c