]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix ALTER DEFAULT PRIVILEGES with duplicated objects
authorMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:39:21 +0000 (11:39 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:39:21 +0000 (11:39 +0900)
commit1c3a4d44d84437b40e8311a0810d2a189e54e291
treef73c3c73919216ebb54db303143b3f13941f8132
parent794562d0770ae0ba4096c57c116e80a2be043fbf
Fix ALTER DEFAULT PRIVILEGES with duplicated objects

Specifying duplicated objects in this command would lead to unique
constraint violations in pg_default_acl or "tuple already updated by
self" errors.  Similarly to GRANT/REVOKE, increment the command ID after
each subcommand processing to allow this case to work transparently.

A regression test is added by tweaking one of the existing queries of
privileges.sql to stress this case.

Reported-by: Andrus
Author: Michael Paquier
Reviewed-by: Álvaro Herrera
Discussion: https://postgr.es/m/ae2a7dc1-9d71-8cba-3bb9-e4cb7eb1f44e@hot.ee
Backpatch-through: 9.5
src/backend/catalog/aclchk.c
src/test/regress/expected/privileges.out
src/test/regress/sql/privileges.sql