]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
[PATCH] CAN-2005-2098 Error during attempt to join key management session can leave...
authorDavid Howells <dhowells@redhat.com>
Wed, 3 Aug 2005 12:19:03 +0000 (13:19 +0100)
committerChris Wright <chrisw@osdl.org>
Mon, 15 Aug 2005 00:20:10 +0000 (17:20 -0700)
commit1cc2029def8e8b279c050b517a3d635b8a8ad351
treef62b6a4ed97f3f9f9fb7085ed3c1651dedaffea4
parent49f8907fb9de31d3a0a099fef0f42ccdcdc9c7e7
[PATCH] CAN-2005-2098 Error during attempt to join key management session can leave semaphore pinned

The attached patch prevents an error during the key session joining operation
from hanging future joins in the D state [CAN-2005-2098].

The problem is that the error handling path for the KEYCTL_JOIN_SESSION_KEYRING
operation has one error path that doesn't release the session management
semaphore. Further attempts to get the semaphore will then sleep for ever in
the D state.

This can happen in four situations, all involving an attempt to allocate a new
session keyring:

 (1) ENOMEM.

 (2) The users key quota being reached.

 (3) A keyring name that is an empty string.

 (4) A keyring name that is too long.

Any user may attempt this operation, and so any user can cause the problem to
occur.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
security/keys/process_keys.c