]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mtd: onenand: Fix uninitialized retlen in do_otp_read()
authorIvan Stepchenko <sid@itb.spb.ru>
Thu, 14 Nov 2024 13:29:51 +0000 (16:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Feb 2025 09:05:41 +0000 (10:05 +0100)
commit1cda594dfad51af05f47faeef9820a4f0475a9f4
tree9baf46839fbf90100da1f67ccb0d8bf6790019f8
parentc9a6200e7932036bf129fcf25eae26ae4658214c
mtd: onenand: Fix uninitialized retlen in do_otp_read()

commit 70a71f8151b9879b0950668ce3ad76263261fee0 upstream.

The function do_otp_read() does not set the output parameter *retlen,
which is expected to contain the number of bytes actually read.
As a result, in onenand_otp_walk(), the tmp_retlen variable remains
uninitialized after calling do_otp_walk() and used to change
the values of the buf, len and retlen variables.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 49dc08eeda70 ("[MTD] [OneNAND] fix numerous races")
Cc: stable@vger.kernel.org
Signed-off-by: Ivan Stepchenko <sid@itb.spb.ru>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/onenand/onenand_base.c