]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: hda: Fix missing pointer check in hda_component_manager_init function
authorDenis Arefev <arefev@swemel.ru>
Thu, 9 Oct 2025 10:50:47 +0000 (13:50 +0300)
committerTakashi Iwai <tiwai@suse.de>
Sat, 11 Oct 2025 06:28:52 +0000 (08:28 +0200)
commit1cf11d80db5df805b538c942269e05a65bcaf5bc
tree71ef49ea9b47c92572ee17337a43d31fc261fb07
parent8527bbb33936340525a3504a00932b2f8fd75754
ALSA: hda: Fix missing pointer check in hda_component_manager_init function

The __component_match_add function may assign the 'matchptr' pointer
the value ERR_PTR(-ENOMEM), which will subsequently be dereferenced.

The call stack leading to the error looks like this:

hda_component_manager_init
|-> component_match_add
    |-> component_match_add_release
        |-> __component_match_add ( ... ,**matchptr, ... )
            |-> *matchptr = ERR_PTR(-ENOMEM);       // assign
|-> component_master_add_with_match( ...  match)
    |-> component_match_realloc(match, match->num); // dereference

Add IS_ERR() check to prevent the crash.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: ae7abe36e352 ("ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops")
Cc: stable@vger.kernel.org
Signed-off-by: Denis Arefev <arefev@swemel.ru>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/side-codecs/hda_component.c