]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
soc: amlogic: canvas: fix device leak on lookup
authorJohan Hovold <johan@kernel.org>
Fri, 26 Sep 2025 14:24:53 +0000 (16:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jan 2026 12:11:52 +0000 (13:11 +0100)
commit1d1b3551f3e8f83c1459c2cb367373bf3473116f
treee1b0ef0467d90a4ea34dc3309a63d573147d694d
parent359824de51952ee0c2227fb06dffadca98cd4bd9
soc: amlogic: canvas: fix device leak on lookup

commit 32200f4828de9d7e6db379909898e718747f4e18 upstream.

Make sure to drop the reference taken to the canvas platform device when
looking up its driver data.

Note that holding a reference to a device does not prevent its driver
data from going away so there is no point in keeping the reference.

Also note that commit 28f851e6afa8 ("soc: amlogic: canvas: add missing
put_device() call in meson_canvas_get()") fixed the leak in a lookup
error path, but the reference is still leaking on success.

Fixes: d4983983d987 ("soc: amlogic: add meson-canvas driver")
Cc: stable@vger.kernel.org # 4.20: 28f851e6afa8
Cc: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://patch.msgid.link/20250926142454.5929-2-johan@kernel.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/soc/amlogic/meson-canvas.c