]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid possible overflow with ltsGetFreeBlock() in logtape.c
authorMichael Paquier <michael@paquier.xyz>
Tue, 29 Aug 2023 23:03:48 +0000 (08:03 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 29 Aug 2023 23:03:48 +0000 (08:03 +0900)
commit1d2939b6dc638f9b9f9e747bec478cb1a7a459b6
tree2f00d03c58526633970fa895861e7f857626d095
parent39d4207e876fa55971cd20a7677b78f067971fd3
Avoid possible overflow with ltsGetFreeBlock() in logtape.c

nFreeBlocks, defined as a long, stores the number of free blocks in a
logical tape.  ltsGetFreeBlock() has been using an int to store the
value of nFreeBlocks, which could lead to overflows on platforms where
long and int are not the same size (in short everything except Windows
where long is 4 bytes).

The problematic intermediate variable is switched to be a long instead
of an int.

Issue introduced by c02fdc9223015, so backpatch down to 13.

Author: Ranier vilela
Reviewed-by: Peter Geoghegan, David Rowley
Discussion: https://postgr.es/m/CAEudQApLDWCBR_xmwNjGBrDo+f+S4E87x3s7-+hoaKqYdtC4JQ@mail.gmail.com
Backpatch-through: 13
src/backend/utils/sort/logtape.c