]> git.ipfire.org Git - thirdparty/coreutils.git/commit
tests: avoid side effects of $SHELL environment variable
authorPádraig Brady <P@draigBrady.com>
Fri, 3 Jul 2015 03:44:05 +0000 (04:44 +0100)
committerPádraig Brady <P@draigBrady.com>
Fri, 3 Jul 2015 12:02:21 +0000 (13:02 +0100)
commit1d4289b3c10f5d8002fd59a518fbb7b148794449
tree2017d1fd33f5c92a9beb44dab5fdda5fb19f0813
parent970b89170206779e028fce6a28f0924c7e47bfd1
tests: avoid side effects of $SHELL environment variable

Since non interactive shells don't generally set $SHELL,
its value is propagated through the tests and may cause issues;
for example if $SHELL implicitly adjusts $PATH when run.
Instead we set $SHELL to that determined by the posix-shell module,
and use that consistently for all test sub scripts,
including those created thorugh the `split --filter` command.

* tests/local.mk: Explicitly set $SHELL to $(PREFERABLY_POSIX_SHELL)
which defaults to $CONFIG_SHELL and thus usually /bin/sh.
* tests/envvar-check: Remove bash environment variables with
side effects, in case /bin/bash was selected for $SHELL.
* tests/misc/help-version.sh: Remove redundant initialization of $SHELL.
* tests/install/strip-program.sh: Use $SHELL for sub script.
* tests/misc/sort-compress-hang.sh: Likewise.
* tests/misc/sort-compress-proc.sh: Likewise.
* tests/misc/sort-compress.sh: Likewise.
* tests/misc/timeout-group.sh: Likewise.
* tests/rm/fail-eperm.xpl: Remove redundant elision of bash env vars.
* tests/misc/pwd-long.sh: Likewise.
tests/envvar-check
tests/install/strip-program.sh
tests/local.mk
tests/misc/help-version.sh
tests/misc/pwd-long.sh
tests/misc/sort-compress-hang.sh
tests/misc/sort-compress-proc.sh
tests/misc/sort-compress.sh
tests/misc/timeout-group.sh
tests/rm/fail-eperm.xpl