]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
PCI/portdrv: Use is_pciehp instead of is_hotplug_bridge
authorLukas Wunner <lukas@wunner.de>
Sun, 13 Jul 2025 14:31:02 +0000 (16:31 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 29 Jul 2025 16:45:39 +0000 (11:45 -0500)
commit1d60796a62f327cd9e0a6a0865ded7656d2c67f9
treec74c90f58693c904b26523a6e5f1cc069f4791ba
parent6cff20ce3b92ffbf2fc5eb9e5a030b3672aa414a
PCI/portdrv: Use is_pciehp instead of is_hotplug_bridge

The PCIe port driver erroneously creates a subdevice for hotplug on ACPI
slots which are handled by the ACPI hotplug driver.

Avoid by checking the is_pciehp flag instead of is_hotplug_bridge when
deciding whether to create a subdevice.  The latter encompasses ACPI slots
whereas the former doesn't.

The superfluous subdevice has no real negative impact, it occupies memory
and interrupt resources but otherwise just sits there waiting for
interrupts from the slot that are never signaled.

Fixes: f8415222837b ("PCI: Use cached copy of PCI_EXP_SLTCAP_HPC bit")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org # v4.7+
Link: https://patch.msgid.link/40d5a5fe8d40595d505949c620a067fa110ee85e.1752390102.git.lukas@wunner.de
drivers/pci/pcie/portdrv.c