]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: xgene-msi: Fix race in installing chained irq handler
authorMartin Kaiser <martin@kaiser.cx>
Fri, 15 Jan 2021 21:24:35 +0000 (22:24 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Mar 2021 15:34:30 +0000 (16:34 +0100)
commit1d706778b4ec6e41b7cbf0e2894fbe57c552ce47
tree90e9acc24c12ef644b632f49cdb0eb1fcf75e1f8
parent3bfe2efebead140ae3e724c3c7087224f812ab37
PCI: xgene-msi: Fix race in installing chained irq handler

[ Upstream commit a93c00e5f975f23592895b7e83f35de2d36b7633 ]

Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

See also 2cf5a03cb29d ("PCI/keystone: Fix race in installing chained IRQ
handler").

Based on the mail discussion, it seems ok to drop the error handling.

Link: https://lore.kernel.org/r/20210115212435.19940-3-martin@kaiser.cx
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/host/pci-xgene-msi.c