]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.12] gh-107219: Fix concurrent.futures terminate_broken() (GH-109244) (#109254)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 2 Oct 2023 14:56:09 +0000 (07:56 -0700)
committerGitHub <noreply@github.com>
Mon, 2 Oct 2023 14:56:09 +0000 (16:56 +0200)
commit1d8c18c39df9ab2a66151041aedb41e450779d96
treeef2ecc269ecaefec8d4ef8576b71773c7dab73b4
parent3e1c9e8264ad9acfef60b3aa9b3aa59bee5becca
[3.12] gh-107219: Fix concurrent.futures terminate_broken() (GH-109244) (#109254)

gh-107219: Fix concurrent.futures terminate_broken() (GH-109244)

Fix a race condition in concurrent.futures. When a process in the
process pool was terminated abruptly (while the future was running or
pending), close the connection write end. If the call queue is
blocked on sending bytes to a worker process, closing the connection
write end interrupts the send, so the queue can be closed.

Changes:

* _ExecutorManagerThread.terminate_broken() now closes
  call_queue._writer.
* multiprocessing PipeConnection.close() now interrupts
  WaitForMultipleObjects() in _send_bytes() by cancelling the
  overlapped operation.
(cherry picked from commit a9b1f84790e977fb09f75b148c4c4f5924a6ef99)

Co-authored-by: Victor Stinner <vstinner@python.org>
Lib/concurrent/futures/process.py
Lib/multiprocessing/connection.py
Misc/NEWS.d/next/Library/2023-09-11-00-32-18.gh-issue-107219.3zqyFT.rst [new file with mode: 0644]