]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ksmbd: Fix dangling pointer in krb_authenticate
authorSean Heelan <seanheelan@gmail.com>
Mon, 7 Apr 2025 11:26:50 +0000 (11:26 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:45:48 +0000 (10:45 +0200)
commit1db2451de23e98bc864c6a6e52aa0d82c91cb325
tree2bf10df7851ca55ba31ad88d52d9bb3a2ee3c782
parent0874b629f65320778e7e3e206177770666d9db18
ksmbd: Fix dangling pointer in krb_authenticate

commit 1e440d5b25b7efccb3defe542a73c51005799a5f upstream.

krb_authenticate frees sess->user and does not set the pointer
to NULL. It calls ksmbd_krb5_authenticate to reinitialise
sess->user but that function may return without doing so. If
that happens then smb2_sess_setup, which calls krb_authenticate,
will be accessing free'd memory when it later uses sess->user.

Cc: stable@vger.kernel.org
Signed-off-by: Sean Heelan <seanheelan@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/smb/server/smb2pdu.c