]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()
authorHaoxiang Li <haoxiang_li2024@163.com>
Mon, 15 Sep 2025 12:09:38 +0000 (20:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:46 +0000 (10:14 +0100)
commit1dcb2f27efb24ad3e74a3aead57b3bd0d6f7dd17
tree43359ae9ff43720415bec8abebeaa40160d4d690
parent59f8c23f2bc214107bc99de8b05a508e00ab7a58
media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init()

commit cdd0f118ef87db8a664fb5ea366fd1766d2df1cd upstream.

vpu_get_plat_device() increases the reference count of the returned
platform device. However, when devm_kzalloc() fails, the reference
is not released, causing a reference leak.

Fix this by calling put_device() on fw_pdev->dev before returning
on the error path.

Fixes: e25a89f743b1 ("media: mtk-vcodec: potential dereference of null pointer")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c